Ticket #4647 (closed defect: fixed)

Opened 4 days ago

Last modified 3 days ago

Clicking on the sort order indicator resets ordering by first column

Reported by: lumi Owned by: zaytsev
Priority: trivial Milestone: 4.8.34
Component: mc-core Version: 4.8.32
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by zaytsev) (diff)

In the core header, the sort order jumps back from modify time to name - happens when the switch is activated.

Attachments

screen-20250201-122903.mp4 (834.0 KB) - added by lumi 4 days ago.

Change History

Changed 4 days ago by lumi

comment:1 Changed 4 days ago by zaytsev

  • Component changed from mc-core to mc-tty
  • Summary changed from Core , window ; header jumps back to Clicking on the sort order indicator resets ordering by first column

comment:2 Changed 4 days ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Description modified (diff)
  • Branch state changed from no branch to on review
  • Milestone set to 4.8.34

Branch: 4647_indicator_click_sort_reverse
Changeset: 08125249226671472542acee07cb1f8137a5ea7e

comment:3 Changed 3 days ago by andrew_b

Mouse clicking area should depend on real width of sort indicator.
I've pushed a fixup.

Last edited 3 days ago by andrew_b (previous) (diff)

comment:4 follow-up: ↓ 5 Changed 3 days ago by zaytsev

  • Votes for changeset set to zaytsev

Oh, wow, I didn't realize that the symbol is actually of variable width, thank you!

comment:5 in reply to: ↑ 4 Changed 3 days ago by andrew_b

Replying to zaytsev:

Oh, wow, I didn't realize that the symbol is actually of variable width, thank you!

I believe, in 99,99% sort indicator occupies two screen cells, but we should support an any width.

comment:6 Changed 3 days ago by andrew_b

  • Votes for changeset changed from zaytsev to zaytsev andrew_b
  • Component changed from mc-tty to mc-core
  • Branch state changed from on review to approved

comment:7 Changed 3 days ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [0a97ffd97904e9ab136e2e497176055511471e19].

git log --oneline 7b89c70ba..0a97ffd97

comment:8 Changed 3 days ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.