Ticket #4613 (closed defect: fixed)

Opened 2 weeks ago

Last modified 12 days ago

Check for ETA overflow

Reported by: js216 Owned by: andrew_b
Priority: trivial Milestone: 4.8.33
Component: mc-core Version: master
Keywords: ETA overflow patch Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

A comment from 11 years ago on the recently closed ticket 3205 noted that for on slow filesystems, the ETA can overflow to a negative number. The ticket was closed but it appears that eta_secs is still not checked for the case when it gets bigger than INT_MAX (about 68 years for 32-bit integers).

Attachments

eta_check.patch​ (693 bytes) - added by js216 2 weeks ago.
Patch to check if eta_secs is too large to display as integer

Change History

Changed 2 weeks ago by js216

Patch to check if eta_secs is too large to display as integer

comment:1 Changed 2 weeks ago by zaytsev

  • Keywords ETA overflow patch added; ETA,overflow,patch removed

comment:2 Changed 13 days ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review

Thanks! Patch applied with some modification.

Branch: 4613_check_eta_overflow
changeset:27c01b894223cbc9d6414bb1bdc253db317dc032

comment:3 Changed 13 days ago by zaytsev

  • Votes for changeset set to zaytsev
  • Branch state changed from on review to approved

comment:4 Changed 12 days ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [7950ae8b246d404844475e13cbe9e74c2e89b805].

comment:5 Changed 12 days ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.