Ticket #4609 (closed enhancement: fixed)

Opened 5 weeks ago

Last modified 3 weeks ago

treat Rust crates as tar.gz files for opening/viewing

Reported by: sharkcz Owned by: zaytsev
Priority: minor Milestone: 4.8.33
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Seem the Rust crates (*.crate) files are actually a gzipped tarball. It would be nice to be able to open/view/inspect them similarly to regular gzipped tarballs.

Change History

comment:1 Changed 5 weeks ago by zaytsev

  • Priority changed from major to minor
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Owner set to zaytsev
  • Milestone changed from Future Releases to 4.8.33

We can add it, but it will be annoying if they change compression, because it's formally unspecified:

​https://users.rust-lang.org/t/where-to-learn-about-crate-file-format/11496/7

​https://github.com/rust-lang/cargo/blob/534ce68621ce4feec0b7e8627cfd3b077d4f3900/src/cargo/ops/cargo_package.rs#L185

Branch: 4609_rust_crate
Changeset: 63a51cdcd72c035b8a6e10107cfd3ce54c545d1a

comment:2 Changed 5 weeks ago by sharkcz

Right, it would be ideal if MC could detect the compression before passing the data to eg. tar. Which might be a useful feature in general ...

comment:3 Changed 5 weeks ago by zaytsev

Well, generally we do have it, but the problem is with nested compression like tar.gz. For this we don't have a great solution. Let's hope that my suggestion is good enough.

comment:4 Changed 5 weeks ago by andrew_b

  • Votes for changeset set to andrew_b
  • Component changed from mc-vfs to mc-core
  • Branch state changed from on review to approved

comment:5 Changed 5 weeks ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [7fc6dfc16bc6a8c86375f3b4fee8a8527a6aa890].

Last edited 3 weeks ago by andrew_b (previous) (diff)

comment:6 Changed 5 weeks ago by sharkcz

tested and it works nicely, thanks

comment:7 Changed 3 weeks ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.