Ticket #4596 (closed defect: fixed)
iso9660 extfs broken
| Reported by: | _that | Owned by: | zaytsev |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.33 |
| Component: | mc-vfs | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
About a week ago I built mc from the current github source. Trying to open an .iso file, I get the error message "isoinfo not found". But isoinfo is installed.
The recent commit 50976ce replaced "which" with "command -v" in some shell scripts, but suppressing its output completely seems to be the wrong thing when assigning the result to a shell variable.
Other extfs helpers may be affected too.
Change History
comment:3 Changed 3 months ago by zaytsev
- Branch state changed from no branch to on review
Branch: 4596_fix_command_v
Initial changeset:14fe1c2f1b62b07fc655a45b53b059cb5f5c54de
I have replaced everything where it's not used as a condition. Sorry, I don't know what I was thinking. Good thing that sometimes people build and test our master. Thank you for reporting!
comment:4 Changed 3 months ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:5 Changed 3 months ago by zaytsev
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master as changeset:b294d650a342cd73e1de539e02c09fc4522caafe
Indeed.
The result of
is nothing. The command should be