Ticket #4567 (closed defect: fixed)
Test fails in iso9660.xorriso in 4.8.32-pre1
| Reported by: | ceamac | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.32 |
| Component: | tests | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description (last modified by zaytsev) (diff)
Test fails in 4.8.32-pre1 (the latest tag on github). The diff is different because some files have the year 2024 instead of 2023.
I'm pastig the test output here and I can attach the full build log if needed.
Thank you!
Testing /mnt/tmp/portage/app-misc/mc-4.8.32_rc1/work/mc-4.8.32-pre1/tests/src/vfs/extfs/helpers-list/data/iso9660.xorriso.input
/mnt/tmp/portage/app-misc/mc-4.8.32_rc1/work/mc-4.8.32-pre1/tests/src/vfs/extfs/helpers-list/data/iso9660.xorriso.output /mnt/tmp/portage/app-misc/mc-4.8.32_rc1/temp/iso9660.actual-parsed-output.pKfVgrtZ differ: char 48, line 1
ERROR: iso9660 has produced output that's different than the expected output.
Expected output (after parsing): /mnt/tmp/portage/app-misc/mc-4.8.32_rc1/work/mc-4.8.32-pre1/tests/src/vfs/extfs/helpers-list/data/iso9660.xorriso.output
Actual output (after parsing): /mnt/tmp/portage/app-misc/mc-4.8.32_rc1/temp/iso9660.actual-parsed-output.pKfVgrtZ
This might mean that a bug was introduced into iso9660. Or that a bug was fixed.
Please compare the files.
If the actual output is the correct one, just copy the latter file
onto the former (and commit to the git repository).
------------ diff of the expected output vs the actual output: ------------- --- /mnt/tmp/portage/app-misc/mc-4.8.32_rc1/work/mc-4.8.32-pre1/tests/src/vfs/extfs/helpers-list/data/iso9660.xorriso.output 2024-08-08 11:20:10.000000000 +0300 +++ /mnt/tmp/portage/app-misc/mc-4.8.32_rc1/temp/iso9660.actual-parsed-output.pKfVgrtZ 2024-08-09 09:53:32.396812447 +0300 @@ -1,14 +1,14 @@ --r--r--r-- 1 0 0 30 2023-12-07 11:48:00 /.alpine-release -dr-xr-xr-x 1 0 0 0 2023-12-07 11:48:00 /boot --r--r--r-- 1 0 0 5751847 2023-12-07 11:48:00 /boot/System.map-lts --r--r--r-- 1 0 0 261013 2023-12-07 11:48:00 /boot/config-lts -dr-xr-xr-x 1 0 0 0 2023-12-07 11:48:00 /boot/dtbs-lts -dr-xr-xr-x 1 0 0 0 2023-12-07 11:48:00 /boot/grub --r--r--r-- 1 0 0 1474560 2023-12-04 23:01:00 /boot/grub/efi.img --r--r--r-- 1 0 0 140 2023-12-07 11:48:00 /boot/grub/grub.cfg --r--r--r-- 1 0 0 20486095 2023-12-07 11:48:00 /boot/initramfs-lts --r--r--r-- 1 0 0 160346112 2023-12-07 11:48:00 /boot/modloop-lts -dr-xr-xr-x 1 0 0 0 2023-12-07 11:48:00 /boot/syslinux --r--r--r-- 1 0 0 2048 2023-12-04 23:01:00 /boot/syslinux/boot.cat +-r--r--r-- 1 0 0 30 2024-12-07 11:48:00 /.alpine-release +dr-xr-xr-x 1 0 0 0 2024-12-07 11:48:00 /boot +-r--r--r-- 1 0 0 5751847 2024-12-07 11:48:00 /boot/System.map-lts +-r--r--r-- 1 0 0 261013 2024-12-07 11:48:00 /boot/config-lts +dr-xr-xr-x 1 0 0 0 2024-12-07 11:48:00 /boot/dtbs-lts +dr-xr-xr-x 1 0 0 0 2024-12-07 11:48:00 /boot/grub +-r--r--r-- 1 0 0 1474560 2024-12-04 23:01:00 /boot/grub/efi.img +-r--r--r-- 1 0 0 140 2024-12-07 11:48:00 /boot/grub/grub.cfg +-r--r--r-- 1 0 0 20486095 2024-12-07 11:48:00 /boot/initramfs-lts +-r--r--r-- 1 0 0 160346112 2024-12-07 11:48:00 /boot/modloop-lts +dr-xr-xr-x 1 0 0 0 2024-12-07 11:48:00 /boot/syslinux +-r--r--r-- 1 0 0 2048 2024-12-04 23:01:00 /boot/syslinux/boot.cat -r--r--r-- 1 0 0 432 2023-05-16 00:00:00 /boot/syslinux/isohdpfx.bin -r--r--r-- 1 0 0 43008 2023-05-16 00:00:00 /boot/syslinux/isolinux.bin @@ -17,9 +17,9 @@ -r--r--r-- 1 0 0 23636 2023-05-16 00:00:00 /boot/syslinux/libutil.c32 -r--r--r-- 1 0 0 11712 2023-05-16 00:00:00 /boot/syslinux/mboot.c32 --r--r--r-- 1 0 0 193 2023-12-07 11:48:00 /boot/syslinux/syslinux.cfg --r--r--r-- 1 0 0 11879168 2023-12-07 11:48:00 /boot/vmlinuz-lts -dr-xr-xr-x 1 0 0 0 2023-12-07 11:48:00 /efi -dr-xr-xr-x 1 0 0 0 2023-12-07 11:48:00 /efi/boot --r--r--r-- 1 0 0 688128 2023-12-07 11:48:00 /efi/boot/bootx64.efi +-r--r--r-- 1 0 0 193 2024-12-07 11:48:00 /boot/syslinux/syslinux.cfg +-r--r--r-- 1 0 0 11879168 2024-12-07 11:48:00 /boot/vmlinuz-lts +dr-xr-xr-x 1 0 0 0 2024-12-07 11:48:00 /efi +dr-xr-xr-x 1 0 0 0 2024-12-07 11:48:00 /efi/boot +-r--r--r-- 1 0 0 688128 2024-12-07 11:48:00 /efi/boot/bootx64.efi drwxr-xr-x 1 0 0 0 2024-05-07 01:28:00 /links -rw-r--r-- 1 0 0 0 2024-05-07 01:28:00 /links/'side-quotes' ------------------------------- end of diff --------------------------------
Attachments
Change History
comment:2 Changed 5 months ago by zaytsev
Related PR - https://github.com/MidnightCommander/mc/pull/196 - asked author to have a look.
comment:3 Changed 5 months ago by ponko
Addressed in https://github.com/MidnightCommander/mc/pull/204
comment:4 Changed 5 months ago by andrew_b
- Owner set to andrew_b
- Status changed from new to accepted
- Votes for changeset set to andrew_b
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.32
Branch: 4567_xorriso_tests
changeset:2971db6226f321561fa2d25b2d25c7e23f17ca5a
comment:5 Changed 5 months ago by zaytsev
- Votes for changeset changed from andrew_b to andrew_b zaytsev
- Branch state changed from on review to approved
comment:6 Changed 5 months ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b zaytsev to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [61267796e2fc813b1c838a1e029a2ba86072999f].
git log --oneline fdcefc942..61267796e
