Ticket #3542 (closed defect: fixed)

Opened 9 years ago

Last modified 2 months ago

[patch] fix /src/editor testsuite failure when ncurses is used

Reported by: and Owned by: zaytsev
Priority: minor Milestone: 4.8.33
Component: tests Version: master
Keywords: Cc:
Blocked By: #4584 Blocking:
Branch state: no branch Votes for changeset:

Description

fix /src/editor testsuite failure when ncurses is used

 Running suite /src/editor
 (null):-1:S:Core:test_autocomplete:0: (after this point) Received signal 11 (Segmentation fault)
 (null):-1:S:Core:test_autocomplete:1: (after this point) Received signal 11 (Segmentation fault)
 (null):-1:S:Core:test_autocomplete_single:0: (after this point) Received signal 11 (Segmentation fault)
 Results for all suites run:
 0%: Checks: 3, Failures: 0, Errors: 3

testsuite failed because ncurses:doupdate() called without proper init

 edit_init()
   -> edit_load_file()
      -> edit_load_file_fast()
         -> status_msg_init()
            -> mc_refesh()
               -> ncurses/tty_refresh()
                  -> doupdate()

patch against 52fd328042a426e885da891c8ce8218cda3a1cf7
compile test with GCC 5.2.0/ncurses 5.9

Signed-off-by: Andreas Mohr <and@…>

Attachments

mc-3542-fix-editor-tests-segfault-on-ncurses.patch (1.4 KB) - added by and 9 years ago.

Change History

comment:1 Changed 9 years ago by andrew_b

  • Milestone changed from 4.8.15 to 4.8.16

comment:2 Changed 9 years ago by zaytsev

  • Milestone changed from 4.8.16 to 4.8.17

comment:3 Changed 9 years ago by zaytsev

  • Milestone changed from 4.8.17 to 4.8.18

comment:4 Changed 8 years ago by zaytsev

  • Milestone changed from 4.8.18 to 4.8.19

comment:5 Changed 7 years ago by zaytsev

  • Milestone changed from 4.8.20 to 4.8.21

comment:6 Changed 7 years ago by zaytsev

  • Milestone changed from 4.8.21 to 4.8.22

comment:7 Changed 6 years ago by zaytsev

  • Milestone changed from 4.8.22 to 4.8.23

comment:8 Changed 6 years ago by zaytsev

  • Milestone changed from 4.8.23 to 4.8.24

comment:9 Changed 4 years ago by zaytsev

  • Milestone changed from 4.8.25 to 4.8.26

comment:10 Changed 4 years ago by zaytsev

  • Milestone changed from 4.8.26 to 4.8.27

comment:11 Changed 4 years ago by andrew_b

  • Milestone changed from 4.8.27 to Future Releases

comment:12 Changed 4 months ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev

This bug is due to mc_refresh mock not being called and instead a real function being called instead. It will be fixed if mocking is generally fixed in tests.

comment:13 Changed 4 months ago by zaytsev

  • Blocked By 4584 added

comment:14 Changed 2 months ago by zaytsev

  • Status changed from accepted to testing
  • Component changed from mc-core to tests
  • Resolution set to fixed
  • Milestone changed from Future Releases to 4.8.33

This should be now fixed in #4584.

comment:15 Changed 2 months ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.