User defined Hotkeys like a VIM

[angel_il]

I've started with rework hotkeys engine.
Target: do this like in a VIM :), with user define hotkeys.

[winnie]

(In #195) Please have a look on #212. This is about configurable shortcuts in general.

[iNode]

(In #21) Double for #195. Also blocked by #212.

[iNode]

(In #21) I checked it in my environment.

All work in mc builded with ncursesw, so it's slang bug.

Please, write bugreport to slang developers or your distro maintainers.

[angel_il]

branch: 212_redefine_hotkeys

for test only

for redefine hotkeys
put in

/usr/share/mc/mc.keymap

[editor]
XStore = ctrl g
XPaste = ctrl v
XCut = ctrl x
Delete-Line = ctrl y

[main]
FindCmd = alt f7
ViewOtherCmd = ctrl o

[panel]
PanelStartSearch = ctrl s
PanelMoveDown = down
PanelMoveUp = up
PanelMoveLeft = left
PanelMoveRight = right
PanelPrevPage = pgup
PanelNextPage = pgdn
PanelDoEnter = enter

[angel_il]

changeset: a4adb6a08adef20c2734ea64c0e35783576e20a7

Wow it worked!!! :)
Welcome review :)

[iNode]

Replying to angel_il:

branch: 212_redefine_hotkeys

for test only

for redefine hotkeys
put in

/usr/share/mc/mc.keymap

path should be etc/mc/mc.keymap

[iNode]

Replying to angel_il:

changeset: a4adb6a08adef20c2734ea64c0e35783576e20a7

Wow it worked!!! :)
Welcome review :)

Yes. Good work, it's work for me too!

But most of users/testers want working keybindings.

I think we should not break current keybindings and
default mc.keymap (at least as example, if without
mc.keymap we has default bindings, but it seems not)
should be also added in context of this ticket.

[iNode]

Replying to iNode:

path should be etc/mc/mc.keymap

ok, mc search it in the order ~/.mc, /etc/mc/, $PREFIX/share/mc,
and I has some mc.keymap. So, angel_il, you are right.

[ierton]

allows user to type binded chars in quicksearch mode

[ierton]

Hi! i am searching for a way to add vim-bindings to mc. i've made some testing of your branch with profile like this:

[panel]
PanelStartSearch=/
PanelMoveDown=j
PanelMoveUp=k
PanelMoveLeft=h
PanelMoveRight=l

and here is the problem:
in qick-search mode (when i type '/') it is impossible to type binded letters (in my case - 'j' 'k' 'h' 'l'). I've attached patch to solve the problem. Check it please! Thank you.

[iNode]

Please don't forget to provide link to branch on review.

[slavazanko]

(In #1390) Just await for complete of #212

I hope, this help to you.

[slavazanko]

(In #397) > It's a semi-solution. In addition to mouse, the shortcut should be provided.

In this case this branch wil continue to develop after megre #212 into master.

[slavazanko]

in 212_redefine_hotkeys branch I added some commits for restore default hotkeys:

• changeset:64b80af536d1deb192e4654d3c5d37d4e7299c8b
• changeset:1585244b09e19c5ddfcc0cc2b3fbf9b2925919e1

Newly added hotkeys don't work. :(

[slavazanko]

Looks good.

[angel_il]

changeset: 10fd8660c1b934d7198e8710dd5f3bd12ed46c27

[angel_il]

Fixed: 10fd8660c1b934d7198e8710dd5f3bd12ed46c27

[slavazanko]

(In #1390) angel_il: Need to give mire info :)

To ticketstarter: now feel to free change ${prefix}/etc/mc/mc.keymap file.
For example, like this:

[panel]
...
PanelSetPanelEncoding = ctrl-u

instread of

PanelSetPanelEncoding = ctrl-t

Enjoy. :)

[slavazanko]

(In #397) See changeset:45c0931f997eeddb327a7defe9a8ffa48ae2c59e

Added function and key binding for toggle sort types.

For review, you may change mc.keymap:

[panel]
...
-PanelToggleSortOrder =
+PanelToggleSortOrder = <some-hotkey>

Review, please.

[slavazanko]

Need to restore editor key bindings.

[angel_il]

branch: 212_fix (patent: master)
chengeset: 7910f97f3c4939c58a190b0958f78bf3dccf87ad

[angel_il]

Please review. ("compleate" fixed)

[angel_il]

Fixed: 53b0f8546d8427b8bc20579e8c4b8aaafcd015cc

[andrew_b]

The button bar uses callbacks for button actions. Therefore F1..F10 keys cannot be overbinded in keymap file. WButtonBar widget must be reimplemented to use keybinding engine.

Created branch 212_buttonbar_commands. Parent branch: master.
inital changeset:07f4bc4a15957a7fbd72c8a80d37cb82a953adda

[andrew_b]

(In #1802) Already fixed in 212_buttonbar_commands branch.

[andrew_b]

Rebased to current master.
Initial changeset:484b796fa3445e129cb3e7ed034f8d5a786209c7
Please review.

[andrew_b]

(In #1764) Replying to gotar:

And I've found similar things in editor:
File/New? C-x k instead C-n
Edit/Beginning? M-< instead C-PgUp?
Edit/End? M-> instead C-PgDn?
Search/Search? again S-F6 instead S-F7

Fixed in 212_buttonbar_commands branch.

[andrew_b]

Merged to master.

git log --pretty=oneline 9531266..6f3b00c

[angel_il]

need remove hardcoded keys from:

• achown.c
• dialog.c
• menu.c
• hotlist.c
• main.c
• widget.c
• something else...

[angel_il]

branch: 212_dialog_hardcoded_hotkeys
changeset: 9b5c360b8355d30e6d8eb3d5bca05edf0be37d37

[angel_il]

212_dialog_hardcoded_hotkeys (forced update)
changeset: ef53bb570746137dd6eea15913483e6dc86fada4

[angel_il]

212_dialog_hardcoded_hotkeys (forced update)
changeset: e9f30aebaee9b35ebc0e4aa8f71e980031c11351

[angel_il]

fixed: 993bb84a8a4b47d9b30294b577b383a59236df38

[andrew_b]

Created 212_listbox_hotkeys branch for implementation of WListbox keybindings.

[andrew_b]

Initial changeset:7a9920c5c1ed743acf67ba91279b9066bde40621

Please review and vote.

[andrew_b]

Merged to master.
changeset:a1dce46339cb7dd0b14ae1c5c8bc6ddb0f104ff8

[andrew_b]

Some hardcoded keys are still used in viewer and in interactive help engine. The 212_viewer_help_hardcoded_keys branch replaces hardcoded keys in these units with keybindings.

212_viewer_help_hardcoded_keys branch. Parent branch is master.
Initial changeset:6b4914b46efcf98c9e388710539bb5a8a59ab649

[andrew_b]

Merged to master.
changeset:9f5b88e49578c6edeea42c8c2eb54ff9afbcf8b1

git log --pretty=oneline a1dce46..9f5b88e

[andrew_b]

The keybind for menu is implemented!

Branch:212_menu_keybind
Initial changeset:ad842d0c6b36adcfdf7107f0ac507cddad289342

Please review.

[andrew_b]

Merged to master: [934a2d9314b621f0a72ba0fe83f18ad2983cd6d6].

git log --pretty=oneline 71c0f7640..934a2d931

[egmont]

Unfortunately these changes broke the hotkeys in the F9 menu.

[andrew_b]

Replying to egmont:

Unfortunately these changes broke the hotkeys in the F9 menu.

Fixed in [7eaa51c79bb74e6e650935e23895c62073ff46c5].

[zaytsev]

In the pulldown menues the <enter> key doesn't work as expected. Menu
items can only be accessed with the letter keys. Instead, enter be-
haves exactly like down-arrow. This is valid for mc and mcedit.

[andrew_b]

Currently I'm using recent mc and menu works fine for me.
I cannot reproduce the described behaviour.

[andrew_b]

See #4006.

Previous ticket properties restored.

[andrew_b]

Key bindings for radiobuttons: [946e8d4888619167502075efd6cb5bc456c03ea9].