Ticket #4615 (closed enhancement: fixed)

Opened 11 days ago

Last modified 6 days ago

ext.d: Select browser at runtime

Reported by: and Owned by: zaytsev
Priority: trivial Milestone: 4.8.33
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Current browser selection happen on compile time and should change to runtime selection.

  • add chromium browser to list
  • bonus: remove shellcheck warning

Attachments

mc-4615-select-browser-at-runtime.patch​ (1.7 KB) - added by and 11 days ago.
mc-4615-01-select-browser-at-runtime-fixup.patch​ (1.2 KB) - added by and 8 days ago.
minor fixes

Change History

Changed 11 days ago by and

comment:1 Changed 11 days ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Milestone changed from Future Releases to 4.8.33

Sounds like a good idea, actually.

TODO: maybe move chromium up the list and add chrome? Not sure what are the most popular browsers on Linux these days.

comment:2 Changed 11 days ago by zaytsev

  • Branch state changed from no branch to on review

Branch: 4615_browser_runtime
Changeset: f8f220da17eaa6cce93ca820e214e4877e604160

Added brave, chrome and safari (open).

comment:3 Changed 11 days ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

I've added a fixup: there are no any substitutions in web.sh anymore.

Last edited 11 days ago by andrew_b (previous) (diff)

comment:4 Changed 10 days ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [87ff8568c57521c84043e40a118b6fe5e7785c9b]

Last edited 10 days ago by andrew_b (previous) (diff)

comment:5 Changed 10 days ago by zaytsev

  • Status changed from testing to closed

Thank you!

Changed 8 days ago by and

minor fixes

comment:6 Changed 8 days ago by and

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:7 Changed 8 days ago by zaytsev

  • Status changed from reopened to accepted
  • Votes for changeset committed-master deleted
  • Branch state changed from merged to on review

Branch: 4615_browser_fixes
Changeset: 8f4b10bdfd5f017d64286cdc0b1505e2ce810064

comment:8 Changed 8 days ago by andrew_b

  • Votes for changeset set to andrew_b
  • Branch state changed from on review to approved

comment:9 Changed 8 days ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged
Version 0, edited 8 days ago by zaytsev (next)

comment:10 Changed 6 days ago by zaytsev

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.